fix(operator): parse flags so they can be configured #1649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Bacher <[email protected]>
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1649 +/- ##
==========================================
+ Coverage 63.48% 63.51% +0.02%
==========================================
Files 142 142
Lines 10892 10892
==========================================
+ Hits 6915 6918 +3
+ Misses 3716 3714 -2
+ Partials 261 260 -1 see 3 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
bacherfl
commented
Jul 3, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
odubajDT
approved these changes
Jul 3, 2023
mowies
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1648
Manually tested this by setting the
--metrics-bind-addressof the lifecycle operator to127.0.0.1:8087, which resulted in the following log during the operator startup: